On Thu, 14 Jun 2007, Urs Beyerle wrote:

>>
>>
>> I don't see why this happens ... Who edits /usr/bin/startkde with sed?
>>
>
> ok, I found it. It is in trigger script of  SL_desktop_tweaks!
>
> this produces the error (in triggerpostun scriptlet):
> # cat /usr/bin/startkde | sed 's:xsetroot -solid \"#5C0B13\":s:xsetroot
> -solid \"#000000\":' > /usr/bin/startkde
>
> fails with
> sed: -e expression #1, char 33: unknown option to `s'
>
> should it be, like this???
> # cat /usr/bin/startkde | sed 's:xsetroot -solid \"#5C0B13\":xsetroot
> -solid \"#000000\":' /usr/bin/startkde

Apart from the destination...

I think the typo is a little clearer if you do:

$ rpm -q SL_desktop_tweaks --triggers | grep 'startkde.*sed' |sed 's/.*|//g'
  sed 's:xsetroot -solid \"#5C0B13\":xsetroot -solid \"#000000\":' > /usr/bin/startkde.tmp
  sed 's:xsetroot -solid \"#5C0B13\":s:xsetroot -solid \"#000000\":' > /usr/bin/startkde.tmp

the spurious 's:' isn't in the other relevant trigger...

> if [ -f /usr/bin/startkde ] ; then
>        cat /usr/bin/startkde | sed 's:xsetroot -solid \"#5C0B13\":s:xsetroot -solid \"#000000\":' > /usr/bin/startkde.tmp
>        mv -f /usr/bin/startkde.tmp /usr/bin/startkde
>        chmod 755 /usr/bin/startkde
> fi

Hmm I don't want to critisize because of the glass-houses stuff but 
possibly using && might be good belt-and-braces here.

Having said that I just spent 20 mins trying to figure out problems caused 
by my use of:

   printf "/isunix\na\ndoccmd = 'WWW'\n.\nw\nq\n" | ed docopt.m

in a script which didn't expct someone to stick a comment in it's way 
(oops).

If you remove SL_desktop_tweaks before the upgrade and put it back 
afterwards it would probably work too.  Given that we now are doing our 
own 'desktop-tweaks' (though not as cleanly as this package!!), I'm no 
longer sure I need SL_desktop_tweaks.

> ...
>
> SL_desktop_tweaks-5-4 should be fixed !!!

The sed on startkde stuff wasn't in the SL_desktop_tweaks for SL4 as far 
as I can see.

If it is being worked on, then the code to 'fix' /etc/X11/gdm/gdm.conf can 
be removed since that no longer exists I think it is /etc/gdm/custom.conf 
these days...

  -- Jon